refactor(form): add return type declarations to Livewire form methods, adjust property types, and remove unused methods and docblocks.

This commit is contained in:
Yoga Pangestu 2025-12-11 19:12:50 +07:00
parent 784e50c00d
commit 7c7e26414b
12 changed files with 31 additions and 46 deletions

View File

@ -14,11 +14,4 @@ public function rules(): array
'email' => ['required', 'string', 'email'], 'email' => ['required', 'string', 'email'],
]; ];
} }
public function validationAttributes(): array
{
return [
'email' => 'email',
];
}
} }

View File

@ -33,7 +33,7 @@ class RegisterForm extends Form
public string $gender = ''; public string $gender = '';
public string $referral_code = ''; public ?string $referral_code = null;
public function rulesStep1(): array public function rulesStep1(): array
{ {

View File

@ -57,7 +57,7 @@ public function validationAttributes(): array
]; ];
} }
public function setBottle(Bottle $bottle) public function setBottle(Bottle $bottle): void
{ {
$this->bottle = $bottle; $this->bottle = $bottle;
@ -70,7 +70,7 @@ public function setBottle(Bottle $bottle)
$this->image = $this->mapMediaCollection($bottle->getMedia('image')); $this->image = $this->mapMediaCollection($bottle->getMedia('image'));
} }
public function store() public function store(): void
{ {
$this->validate(); $this->validate();
@ -83,7 +83,7 @@ public function store()
}); });
} }
public function update() public function update(): void
{ {
$this->validate(); $this->validate();

View File

@ -43,7 +43,7 @@ public function validationAttributes(): array
]; ];
} }
public function store() public function store(): array
{ {
$this->validate(); $this->validate();
@ -79,6 +79,7 @@ public function store()
$payroll->save(); $payroll->save();
} }
}); });
if ($adjustment->type->value == SalaryAdjustmentType::BONUS->value) { if ($adjustment->type->value == SalaryAdjustmentType::BONUS->value) {
return [ return [
'userIds' => $this->user_ids, 'userIds' => $this->user_ids,
@ -91,9 +92,4 @@ public function store()
]; ];
} }
} }
public function update()
{
$this->validate();
}
} }

View File

@ -29,7 +29,7 @@ public function validationAttributes(): array
]; ];
} }
public function setFaq(Faq $faq) public function setFaq(Faq $faq): void
{ {
$this->faq = $faq; $this->faq = $faq;
@ -37,7 +37,7 @@ public function setFaq(Faq $faq)
$this->answer = $faq->answer; $this->answer = $faq->answer;
} }
public function store() public function store(): void
{ {
$this->validate(); $this->validate();
@ -48,7 +48,7 @@ public function store()
]); ]);
} }
public function update() public function update(): void
{ {
$this->validate(); $this->validate();
@ -58,7 +58,7 @@ public function update()
]); ]);
} }
public function delete() public function delete(): void
{ {
$this->faq->delete(); $this->faq->delete();
@ -70,7 +70,7 @@ public function delete()
}); });
} }
public function sortOrder(string $direction) public function sortOrder(string $direction): void
{ {
if (in_array($direction, ['up', 'down'])) { if (in_array($direction, ['up', 'down'])) {
$swap = null; $swap = null;
@ -99,7 +99,7 @@ public function sortOrder(string $direction)
} }
} }
protected function normalizeSortOrder() protected function normalizeSortOrder(): void
{ {
$categories = Faq::orderBy('sort_order')->get(); $categories = Faq::orderBy('sort_order')->get();
foreach ($categories as $index => $faq) { foreach ($categories as $index => $faq) {

View File

@ -38,7 +38,7 @@ public function validationAttributes(): array
]; ];
} }
public function setCustomer(Customer $customer) public function setCustomer(Customer $customer): void
{ {
$this->customer = $customer; $this->customer = $customer;
@ -47,7 +47,7 @@ public function setCustomer(Customer $customer)
$this->gender = $customer->gender->value; $this->gender = $customer->gender->value;
} }
public function store() public function store(): void
{ {
$this->validate(); $this->validate();
@ -59,7 +59,7 @@ public function store()
]); ]);
} }
public function update() public function update(): void
{ {
$this->validate(); $this->validate();

View File

@ -34,7 +34,7 @@ public function validationAttributes(): array
]; ];
} }
public function setRewards(TierReward $tierReward) public function setRewards(TierReward $tierReward): void
{ {
$this->tierReward = $tierReward; $this->tierReward = $tierReward;
@ -43,14 +43,14 @@ public function setRewards(TierReward $tierReward)
$this->value = currency($tierReward->value); $this->value = currency($tierReward->value);
} }
public function store() public function store(): TierReward
{ {
$this->validate(); $this->validate();
return TierReward::create($this->prepareSavedData()); return TierReward::create($this->prepareSavedData());
} }
public function update() public function update(): TierReward
{ {
$this->validate(); $this->validate();
@ -59,7 +59,7 @@ public function update()
return $this->tierReward; return $this->tierReward;
} }
private function prepareSavedData() private function prepareSavedData(): array
{ {
return [ return [
'tier_id' => $this->tier_id, 'tier_id' => $this->tier_id,

View File

@ -97,7 +97,7 @@ public function validationAttributes(): array
]; ];
} }
public function setVoucher(Voucher $voucher) public function setVoucher(Voucher $voucher): void
{ {
$voucher->load('outlets'); $voucher->load('outlets');
@ -119,7 +119,7 @@ public function setVoucher(Voucher $voucher)
$this->outlet_ids = $this->voucher->outlets->pluck('id')->toArray(); $this->outlet_ids = $this->voucher->outlets->pluck('id')->toArray();
} }
public function store() public function store(): void
{ {
$this->validate(); $this->validate();
@ -138,7 +138,7 @@ public function store()
}); });
} }
public function update() public function update(): void
{ {
$this->validate(); $this->validate();
@ -152,7 +152,7 @@ public function update()
}); });
} }
private function prepareSavedData() private function prepareSavedData(): array
{ {
return [ return [
'name' => $this->name, 'name' => $this->name,

View File

@ -78,7 +78,7 @@ public function validationAttributes(): array
]; ];
} }
public function store() public function store(): array
{ {
$this->validate(); $this->validate();

View File

@ -68,7 +68,7 @@ public function validationAttributes(): array
]; ];
} }
public function setPurchase(Purchase $purchase) public function setPurchase(Purchase $purchase): void
{ {
$this->purchase = $purchase; $this->purchase = $purchase;
@ -81,7 +81,7 @@ public function setPurchase(Purchase $purchase)
$this->image = $this->mapMediaCollection($purchase->getMedia('image')); $this->image = $this->mapMediaCollection($purchase->getMedia('image'));
} }
public function store() public function store(): void
{ {
$this->validate(); $this->validate();
@ -102,7 +102,7 @@ public function store()
}); });
} }
public function update() public function update(): void
{ {
$this->validate(); $this->validate();

View File

@ -15,7 +15,7 @@ class StockOpnameForm extends Form
public ?string $note = null; public ?string $note = null;
public function rules() public function rules(): array
{ {
return [ return [
'outlet_stock' => 'array', 'outlet_stock' => 'array',
@ -24,7 +24,7 @@ public function rules()
]; ];
} }
public function validationAttributes() public function validationAttributes(): array
{ {
return [ return [
'outlet_stock' => 'stock outlet', 'outlet_stock' => 'stock outlet',
@ -33,7 +33,7 @@ public function validationAttributes()
]; ];
} }
public function setStockOpname(StockOpname $stockOpname) public function setStockOpname(StockOpname $stockOpname): void
{ {
$stockOpname->load('items'); $stockOpname->load('items');
@ -42,7 +42,7 @@ public function setStockOpname(StockOpname $stockOpname)
$this->note = $stockOpname->note; $this->note = $stockOpname->note;
} }
public function update() public function update(): void
{ {
$this->validate(); $this->validate();

View File

@ -28,20 +28,16 @@ class OutletForm extends Form
public ?string $maps_url = null; public ?string $maps_url = null;
/** @var array<string, array{open_time: ?string, close_time: ?string}> */
public array $opening_hours = []; public array $opening_hours = [];
/** @var array<int, string> */
public array $facilities = ['Parkir']; public array $facilities = ['Parkir'];
public string $opened_date = ''; public string $opened_date = '';
public int $status = OutletStatus::OPERATIONAL->value; public int $status = OutletStatus::OPERATIONAL->value;
/** @var array<int, array<string, mixed>> */
public array $featured_image = []; public array $featured_image = [];
/** @var array<int, array<string, mixed>> */
public array $images = []; public array $images = [];
public function rules(): array public function rules(): array