yadiparfum/parfum
yadiparfum/parfum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(helpers): Remove unused currency and percentage formatting functions from StringHelpers.php and add NumberHelpers.php for improved organization and maintainability.

Browse Source
This commit is contained in:
Yoga Pangestu 2025-12-14 15:51:36 +07:00
parent a7427f145f
commit 437fde9d7e
3 changed files with 70 additions and 66 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
app/Helpers/NumberHelpers.php Normal file
View File

@ -0,0 +1,68 @@
<?php
use App\Enums\VoucherType;
use Illuminate\Support\Number;
use Illuminate\Support\Str;
if (! function_exists('formatCurrencyNumber')) {
/**
* Format value as currency
*
* @param string|null $currency Currency prefix (default: null)
* @param string $locale Locale for formatting (default: 'id_ID')
*/
function formatCurrencyNumber(string|int|float|null $value = null, ?string $currency = null, string $locale = 'id_ID'): string
{
if ($value === null) {
return '';
}
return $currency.Number::format($value, locale: $locale);
}
}
if (! function_exists('parseRupiahToInt')) {
/**
* Strip currency format from string and return as integer
*/
function parseRupiahToInt(?string $value = null): ?int
{
if ($value === null) {
return null;
}
$cleaned = Str::of($value)
->replace('Rp', '')
->replace('.', '')
->replace(' ', '')
->__toString();
return (int) $cleaned;
}
}
if (! function_exists('formatPercentage')) {
/**
* Format value as percentage
*
* @param int $precision Precision (default: 2)
* @param int $maxPrecision Max precision (default: 2)
* @param string $locale Locale for formatting (default: 'id_ID')
*/
function formatPercentage(int|float $value, int $precision = 2, int $maxPrecision = 2, string $locale = 'id_ID'): string
{
return Number::percentage($value, $precision, $maxPrecision, $locale);
}
}
if (! function_exists('formatDiscount')) {
/**
* Format discount based on voucher type (percentage or fixed amount)
*/
function formatDiscount(int|float $amount, VoucherType $type, string $currency = 'Rp'): string
{
return $type === VoucherType::PERCENTAGE
? formatPercentage($amount)
: formatCurrencyNumber($amount, $currency);
}
}

65
app/Helpers/StringHelpers.php
View File

@ -1,72 +1,7 @@
<?php
use App\Enums\VoucherType;
use Illuminate\Support\Number;
use Illuminate\Support\Str;
if (! function_exists('formatCurrencyNumber')) {
/**
* Format value as currency
*
* @param string|null $currency Currency prefix (default: null)
* @param string $locale Locale for formatting (default: 'id_ID')
*/
function formatCurrencyNumber(string|int|float|null $value = null, ?string $currency = null, string $locale = 'id_ID'): string
{
if ($value === null) {
return '';
}
return $currency.Number::format($value, locale: $locale);
}
}
if (! function_exists('parseRupiahToInt')) {
/**
* Strip currency format from string and return as integer
*/
function parseRupiahToInt(?string $value = null): ?int
{
if ($value === null) {
return null;
}
$cleaned = Str::of($value)
->replace('Rp', '')
->replace('.', '')
->replace(' ', '')
->__toString();
return (int) $cleaned;
}
}
if (! function_exists('formatPercentage')) {
/**
* Format value as percentage
*
* @param int $precision Precision (default: 2)
* @param int $maxPrecision Max precision (default: 2)
* @param string $locale Locale for formatting (default: 'id_ID')
*/
function formatPercentage(int|float $value, int $precision = 2, int $maxPrecision = 2, string $locale = 'id_ID'): string
{
return Number::percentage($value, $precision, $maxPrecision, $locale);
}
}
if (! function_exists('formatDiscount')) {
/**
* Format discount based on voucher type (percentage or fixed amount)
*/
function formatDiscount(int|float $amount, VoucherType $type, string $currency = 'Rp'): string
{
return $type === VoucherType::PERCENTAGE
? formatPercentage($amount)
: formatCurrencyNumber($amount, $currency);
}
}
if (! function_exists('generateReferralCode')) {
/**
* Generate referral code from username and unique number

3
composer.json
View File

@ -52,7 +52,8 @@
"files": [
"app/Helpers/DateTimeHelpers.php",
"app/Helpers/StringHelpers.php",
"app/Helpers/ColorHelpers.php"
"app/Helpers/ColorHelpers.php",
"app/Helpers/NumberHelpers.php"
]
},
"autoload-dev": {