From 8d86d696b44ee430fe291d9dde417133478109fd Mon Sep 17 00:00:00 2001 From: Yoga Pangestu Date: Sun, 29 Mar 2026 23:20:48 +0700 Subject: [PATCH] refactor: simplify class references in GenerateDailySessions command for improved readability --- app/Console/Commands/GenerateDailySessions.php | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/app/Console/Commands/GenerateDailySessions.php b/app/Console/Commands/GenerateDailySessions.php index f7646f6..37f5988 100644 --- a/app/Console/Commands/GenerateDailySessions.php +++ b/app/Console/Commands/GenerateDailySessions.php @@ -2,6 +2,9 @@ namespace App\Console\Commands; +use App\Models\ClassSession; +use App\Models\CourseSchedule; +use App\Settings\GeneralSettings; use Illuminate\Console\Command; class GenerateDailySessions extends Command @@ -21,9 +24,9 @@ class GenerateDailySessions extends Command public function handle() { $dayOfWeek = now()->dayOfWeekIso; // 1 (Mon) - 7 (Sun) - $currentSemester = app(\App\Settings\GeneralSettings::class)->current_semester; + $currentSemester = app(GeneralSettings::class)->current_semester; - $schedules = \App\Models\CourseSchedule::query() + $schedules = CourseSchedule::query() ->where('day_of_week', $dayOfWeek) ->whereHas('course', function ($query) use ($currentSemester) { $query->where('semester', $currentSemester); @@ -32,14 +35,14 @@ public function handle() $count = 0; foreach ($schedules as $schedule) { - $exists = \App\Models\ClassSession::where('course_id', $schedule->course_id) + $exists = ClassSession::where('course_id', $schedule->course_id) ->whereDate('date', now()) ->exists(); if (! $exists) { - $lastSession = \App\Models\ClassSession::where('course_id', $schedule->course_id)->max('session_number'); + $lastSession = ClassSession::where('course_id', $schedule->course_id)->max('session_number'); - \App\Models\ClassSession::create([ + ClassSession::create([ 'course_id' => $schedule->course_id, 'session_number' => ($lastSession ?? 0) + 1, 'date' => now()->toDateString(),