From 37f2c7885248259d7adf5bfdc659d49016e6519c Mon Sep 17 00:00:00 2001 From: Yoga Pangestu Date: Thu, 2 Apr 2026 13:10:33 +0700 Subject: [PATCH] refactor: remove redundant route binding overrides and unused attendance relation manager --- .../ClassSessions/ClassSessionResource.php | 17 ----------------- .../Learning/Materials/MaterialResource.php | 9 --------- .../Resources/Master/Courses/CourseResource.php | 10 ---------- 3 files changed, 36 deletions(-) diff --git a/app/Filament/Resources/Learning/ClassSessions/ClassSessionResource.php b/app/Filament/Resources/Learning/ClassSessions/ClassSessionResource.php index 5172d1e..75bf799 100644 --- a/app/Filament/Resources/Learning/ClassSessions/ClassSessionResource.php +++ b/app/Filament/Resources/Learning/ClassSessions/ClassSessionResource.php @@ -4,13 +4,11 @@ use App\Filament\Resources\Learning\ClassSessions\Pages\ListCourseSessions; use App\Filament\Resources\Learning\ClassSessions\Pages\ManageClassSessions; -use App\Filament\Resources\Learning\ClassSessions\RelationManagers\AttendanceRelationManager; use App\Models\ClassSession; use App\Settings\GeneralSettings; use BackedEnum; use Filament\Resources\Resource; use Illuminate\Database\Eloquent\Builder; -use Illuminate\Database\Eloquent\SoftDeletingScope; use UnitEnum; class ClassSessionResource extends Resource @@ -27,13 +25,6 @@ class ClassSessionResource extends Resource protected static ?string $slug = 'learning/class-sessions'; - public static function getRelations(): array - { - return [ - AttendanceRelationManager::class, - ]; - } - public static function getPages(): array { return [ @@ -49,12 +40,4 @@ public static function getEloquentQuery(): Builder $query->where('semester', app(GeneralSettings::class)->current_semester); }); } - - public static function getRecordRouteBindingEloquentQuery(): Builder - { - return parent::getRecordRouteBindingEloquentQuery() - ->withoutGlobalScopes([ - SoftDeletingScope::class, - ]); - } } diff --git a/app/Filament/Resources/Learning/Materials/MaterialResource.php b/app/Filament/Resources/Learning/Materials/MaterialResource.php index 252f09c..5dfaee1 100644 --- a/app/Filament/Resources/Learning/Materials/MaterialResource.php +++ b/app/Filament/Resources/Learning/Materials/MaterialResource.php @@ -33,7 +33,6 @@ use Filament\Tables\Filters\TrashedFilter; use Filament\Tables\Table; use Illuminate\Database\Eloquent\Builder; -use Illuminate\Database\Eloquent\SoftDeletingScope; use UnitEnum; class MaterialResource extends Resource @@ -219,12 +218,4 @@ public static function getEloquentQuery(): Builder $query->where('semester', app(GeneralSettings::class)->current_semester); }); } - - public static function getRecordRouteBindingEloquentQuery(): Builder - { - return parent::getRecordRouteBindingEloquentQuery() - ->withoutGlobalScopes([ - SoftDeletingScope::class, - ]); - } } diff --git a/app/Filament/Resources/Master/Courses/CourseResource.php b/app/Filament/Resources/Master/Courses/CourseResource.php index 9becb48..749a370 100644 --- a/app/Filament/Resources/Master/Courses/CourseResource.php +++ b/app/Filament/Resources/Master/Courses/CourseResource.php @@ -10,8 +10,6 @@ use Filament\Resources\Resource; use Filament\Schemas\Schema; use Filament\Tables\Table; -use Illuminate\Database\Eloquent\Builder; -use Illuminate\Database\Eloquent\SoftDeletingScope; use UnitEnum; class CourseResource extends Resource @@ -44,12 +42,4 @@ public static function getPages(): array 'index' => ManageCourses::route('/'), ]; } - - public static function getRecordRouteBindingEloquentQuery(): Builder - { - return parent::getRecordRouteBindingEloquentQuery() - ->withoutGlobalScopes([ - SoftDeletingScope::class, - ]); - } }