itm/itmpwk.ac.id
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: remove redundant date validation logic from AcademicTermRequest

Browse Source
This commit is contained in:
Yoga Pangestu 2026-09-02 13:26:55 +07:00
parent ded7217dbc
commit 9823b879d8
1 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
app/Http/Requests/Admin/Master/AcademicTermRequest.php
View File

@ -46,37 +46,11 @@ function ($attribute, $value, $fail) {
'start_date' => [ 'start_date' => [
'required', 'required',
'date', 'date',
function ($attribute, $value, $fail) {
$academicYear = $this->input('academic_year');
$semester = $this->input('semester');
if ($academicYear && preg_match('/^(\d{4})\/(\d{4})$/', $academicYear, $matches)) {
$startYear = (int) $matches[1];
$endYear = (int) $matches[2];
$dateYear = (int) date('Y', strtotime($value));
$expectedYear = $semester === 'even' ? $endYear : $startYear;
if ($dateYear !== $expectedYear) {
$fail('Start date harus berada di tahun '.$expectedYear.' untuk semester '.($semester === 'even' ? 'Genap' : 'Ganjil').'.');
}
}
},
], ],
'end_date' => [ 'end_date' => [
'required', 'required',
'date', 'date',
'after_or_equal:start_date', 'after_or_equal:start_date',
function ($attribute, $value, $fail) {
$academicYear = $this->input('academic_year');
$semester = $this->input('semester');
if ($academicYear && preg_match('/^(\d{4})\/(\d{4})$/', $academicYear, $matches)) {
$startYear = (int) $matches[1];
$endYear = (int) $matches[2];
$dateYear = (int) date('Y', strtotime($value));
$expectedYear = $semester === 'even' ? $endYear : $startYear;
if ($dateYear !== $expectedYear) {
$fail('End date harus berada di tahun '.$expectedYear.' untuk semester '.($semester === 'even' ? 'Genap' : 'Ganjil').'.');
}
}
},
], ],
'is_active' => ['boolean'], 'is_active' => ['boolean'],
'open_semesters' => ['nullable', 'array'], 'open_semesters' => ['nullable', 'array'],