refactor: implement error handling in EmployeeAdvanceService methods to ensure transaction safety and improve code robustness

This commit is contained in:
Yoga Pangestu 2026-06-25 20:39:36 +07:00
parent a3d5ac2eb2
commit abe84899c9

View File

@ -76,6 +76,7 @@ public function create(array $validated, User $user): void
{ {
$employee = $this->resolveAuthenticatedEmployee($user); $employee = $this->resolveAuthenticatedEmployee($user);
try {
$employeeAdvance = DB::transaction(function () use ($validated, $employee) { $employeeAdvance = DB::transaction(function () use ($validated, $employee) {
return EmployeeAdvance::create([ return EmployeeAdvance::create([
'employee_id' => $employee->id, 'employee_id' => $employee->id,
@ -85,12 +86,15 @@ public function create(array $validated, User $user): void
'status' => EmployeeAdvanceStatus::PENDING, 'status' => EmployeeAdvanceStatus::PENDING,
]); ]);
}); });
} catch (\Throwable $e) {
throw $e;
}
$this->pushNotificationService->sendToRoles( $this->pushNotificationService->sendToRoles(
'💰 Pengajuan Kasbon Baru', '💰 Pengajuan Kasbon Baru',
"Karyawan {$user->profil?->full_name} mengajukan kasbon sebesar {$employeeAdvance->amount_formatted} dengan keterangan: {$employeeAdvance->description}.", "Karyawan {$user->profil?->full_name} mengajukan kasbon sebesar {$employeeAdvance->amount_formatted} dengan keterangan: {$employeeAdvance->description}.",
['owner', 'developer'], ['owner', 'developer'],
route('admin.finance.employee-advances.index'), route('admin.finance.employee_advances.index'),
); );
} }
@ -99,6 +103,7 @@ public function create(array $validated, User $user): void
*/ */
public function update(EmployeeAdvance $employeeAdvance, array $validated, User $user): void public function update(EmployeeAdvance $employeeAdvance, array $validated, User $user): void
{ {
try {
DB::transaction(function () use ($employeeAdvance, $validated): void { DB::transaction(function () use ($employeeAdvance, $validated): void {
$employeeAdvance->update([ $employeeAdvance->update([
'amount' => (int) $validated['amount'], 'amount' => (int) $validated['amount'],
@ -106,12 +111,15 @@ public function update(EmployeeAdvance $employeeAdvance, array $validated, User
'due_date' => $validated['due_date'], 'due_date' => $validated['due_date'],
]); ]);
}); });
} catch (\Throwable $e) {
throw $e;
}
$this->pushNotificationService->sendToRoles( $this->pushNotificationService->sendToRoles(
'✏️ Kasbon Diperbarui', '✏️ Kasbon Diperbarui',
"Kasbon sebesar {$employeeAdvance->amount_formatted} telah diperbarui oleh {$user->profile?->full_name}.", "Kasbon sebesar {$employeeAdvance->amount_formatted} telah diperbarui oleh {$user->profile?->full_name}.",
['owner', 'developer'], ['owner', 'developer'],
route('admin.finance.employee-advances.index'), route('admin.finance.employee_advances.index'),
); );
} }
@ -126,12 +134,13 @@ public function delete(EmployeeAdvance $employeeAdvance, User $user): void
'🗑️ Kasbon Dihapus', '🗑️ Kasbon Dihapus',
"Kasbon sebesar {$amount} dengan keterangan {$description} telah dihapus.", "Kasbon sebesar {$amount} dengan keterangan {$description} telah dihapus.",
['owner', 'developer'], ['owner', 'developer'],
route('admin.finance.employee-advances.index'), route('admin.finance.employee_advances.index'),
); );
} }
public function approve(EmployeeAdvance $employeeAdvance, User $user): void public function approve(EmployeeAdvance $employeeAdvance, User $user): void
{ {
try {
DB::transaction(function () use ($employeeAdvance, $user): void { DB::transaction(function () use ($employeeAdvance, $user): void {
$employeeAdvance->loadMissing('employee.user.profile'); $employeeAdvance->loadMissing('employee.user.profile');
@ -154,6 +163,9 @@ public function approve(EmployeeAdvance $employeeAdvance, User $user): void
'verified_by_id' => $user->id, 'verified_by_id' => $user->id,
]); ]);
}); });
} catch (\Throwable $e) {
throw $e;
}
$employeeAdvance->loadMissing('employee.user'); $employeeAdvance->loadMissing('employee.user');
if ($employeeAdvance->employee?->user_id) { if ($employeeAdvance->employee?->user_id) {
@ -161,13 +173,14 @@ public function approve(EmployeeAdvance $employeeAdvance, User $user): void
'💰 Kasbon Disetujui', '💰 Kasbon Disetujui',
"Pengajuan kasbon Anda sebesar {$employeeAdvance->amount_formatted} telah disetujui.", "Pengajuan kasbon Anda sebesar {$employeeAdvance->amount_formatted} telah disetujui.",
$employeeAdvance->employee->user_id, $employeeAdvance->employee->user_id,
route('admin.finance.employee-advances.index'), route('admin.finance.employee_advances.index'),
); );
} }
} }
public function reject(EmployeeAdvance $employeeAdvance, string $reason, User $user): void public function reject(EmployeeAdvance $employeeAdvance, string $reason, User $user): void
{ {
try {
DB::transaction(function () use ($employeeAdvance, $user, $reason): void { DB::transaction(function () use ($employeeAdvance, $user, $reason): void {
$employeeAdvance->update([ $employeeAdvance->update([
'status' => EmployeeAdvanceStatus::REJECTED, 'status' => EmployeeAdvanceStatus::REJECTED,
@ -180,6 +193,9 @@ public function reject(EmployeeAdvance $employeeAdvance, string $reason, User $u
'rejected_by_id' => $user->id, 'rejected_by_id' => $user->id,
]); ]);
}); });
} catch (\Throwable $e) {
throw $e;
}
$employeeAdvance->loadMissing('employee.user'); $employeeAdvance->loadMissing('employee.user');
if ($employeeAdvance->employee?->user_id) { if ($employeeAdvance->employee?->user_id) {
@ -187,13 +203,14 @@ public function reject(EmployeeAdvance $employeeAdvance, string $reason, User $u
'💰 Kasbon Ditolak', '💰 Kasbon Ditolak',
"Pengajuan kasbon Anda sebesar {$employeeAdvance->amount_formatted} ditolak dengan alasan: {$reason}.", "Pengajuan kasbon Anda sebesar {$employeeAdvance->amount_formatted} ditolak dengan alasan: {$reason}.",
$employeeAdvance->employee->user_id, $employeeAdvance->employee->user_id,
route('admin.finance.employee-advances.index'), route('admin.finance.employee_advances.index'),
); );
} }
} }
public function pay(EmployeeAdvance $employeeAdvance, User $user): void public function pay(EmployeeAdvance $employeeAdvance, User $user): void
{ {
try {
DB::transaction(function () use ($employeeAdvance, $user): void { DB::transaction(function () use ($employeeAdvance, $user): void {
$employeeAdvance->loadMissing('employee.user.profile'); $employeeAdvance->loadMissing('employee.user.profile');
@ -216,6 +233,9 @@ public function pay(EmployeeAdvance $employeeAdvance, User $user): void
'status' => EmployeeAdvanceStatus::PAID, 'status' => EmployeeAdvanceStatus::PAID,
]); ]);
}); });
} catch (\Throwable $e) {
throw $e;
}
} }
private function applySorting(Builder $query, string $sort, string $direction): void private function applySorting(Builder $query, string $sort, string $direction): void