refactor: remove unnecessary clearMediaCollection calls in various services to improve performance
This commit is contained in:
parent
ba01039b41
commit
a29e6af430
@ -283,7 +283,6 @@ function () use ($transaction): void {
|
|||||||
|
|
||||||
$account = $transaction->cashAccount;
|
$account = $transaction->cashAccount;
|
||||||
|
|
||||||
$transaction->clearMediaCollection('photos');
|
|
||||||
$transaction->delete();
|
$transaction->delete();
|
||||||
|
|
||||||
$this->recalculateBalances($account);
|
$this->recalculateBalances($account);
|
||||||
|
|||||||
@ -133,7 +133,6 @@ function () use ($expense): void {
|
|||||||
$this->cashService->deleteReferencedTransaction($expense->cashTransaction);
|
$this->cashService->deleteReferencedTransaction($expense->cashTransaction);
|
||||||
}
|
}
|
||||||
|
|
||||||
$expense->clearMediaCollection('photos');
|
|
||||||
$expense->delete();
|
$expense->delete();
|
||||||
},
|
},
|
||||||
'Gagal menghapus pengeluaran',
|
'Gagal menghapus pengeluaran',
|
||||||
|
|||||||
@ -172,8 +172,6 @@ public function delete(Attendance $attendance, User $user): void
|
|||||||
|
|
||||||
$this->runInTransaction(
|
$this->runInTransaction(
|
||||||
function () use ($attendance): void {
|
function () use ($attendance): void {
|
||||||
$attendance->clearMediaCollection('checkin');
|
|
||||||
$attendance->clearMediaCollection('checkout');
|
|
||||||
$attendance->delete();
|
$attendance->delete();
|
||||||
},
|
},
|
||||||
'Gagal menghapus presensi',
|
'Gagal menghapus presensi',
|
||||||
|
|||||||
@ -680,7 +680,6 @@ function () use ($cutting): void {
|
|||||||
|
|
||||||
$cutting->materials()->delete();
|
$cutting->materials()->delete();
|
||||||
$cutting->results()->delete();
|
$cutting->results()->delete();
|
||||||
$cutting->clearMediaCollection('images');
|
|
||||||
$cutting->delete();
|
$cutting->delete();
|
||||||
},
|
},
|
||||||
'Gagal menghapus proses cutting',
|
'Gagal menghapus proses cutting',
|
||||||
|
|||||||
@ -716,7 +716,6 @@ private function rejectCreate(OwnerVerificationRequest $verificationRequest): vo
|
|||||||
|
|
||||||
$this->runInTransaction(
|
$this->runInTransaction(
|
||||||
function () use ($purchase): void {
|
function () use ($purchase): void {
|
||||||
$purchase->clearMediaCollection('photos');
|
|
||||||
$purchase->items()->delete();
|
$purchase->items()->delete();
|
||||||
$purchase->delete();
|
$purchase->delete();
|
||||||
},
|
},
|
||||||
@ -734,7 +733,6 @@ function () use ($purchase): void {
|
|||||||
$this->decrementStock($item);
|
$this->decrementStock($item);
|
||||||
}
|
}
|
||||||
|
|
||||||
$purchase->clearMediaCollection('photos');
|
|
||||||
$purchase->items()->delete();
|
$purchase->items()->delete();
|
||||||
$purchase->delete();
|
$purchase->delete();
|
||||||
},
|
},
|
||||||
|
|||||||
@ -573,7 +573,6 @@ private function rejectCreate(OwnerVerificationRequest $verificationRequest): vo
|
|||||||
|
|
||||||
$this->runInTransaction(
|
$this->runInTransaction(
|
||||||
function () use ($restock): void {
|
function () use ($restock): void {
|
||||||
$restock->clearMediaCollection('photos');
|
|
||||||
$restock->items()->delete();
|
$restock->items()->delete();
|
||||||
$restock->delete();
|
$restock->delete();
|
||||||
},
|
},
|
||||||
@ -593,7 +592,6 @@ function () use ($restock): void {
|
|||||||
$this->decrementStock($item, $stockType);
|
$this->decrementStock($item, $stockType);
|
||||||
}
|
}
|
||||||
|
|
||||||
$restock->clearMediaCollection('photos');
|
|
||||||
$restock->items()->delete();
|
$restock->items()->delete();
|
||||||
$restock->delete();
|
$restock->delete();
|
||||||
},
|
},
|
||||||
|
|||||||
@ -523,7 +523,6 @@ private function applyPayloadToProduct(
|
|||||||
->whereNotIn('id', $submittedVariantIds)
|
->whereNotIn('id', $submittedVariantIds)
|
||||||
->get()
|
->get()
|
||||||
->each(function (ProductVariant $variant): void {
|
->each(function (ProductVariant $variant): void {
|
||||||
$variant->clearMediaCollection('images');
|
|
||||||
$variant->delete();
|
$variant->delete();
|
||||||
});
|
});
|
||||||
|
|
||||||
@ -590,9 +589,6 @@ private function applyDeleteSubject(Product $product): void
|
|||||||
{
|
{
|
||||||
$this->runInTransaction(
|
$this->runInTransaction(
|
||||||
function () use ($product): void {
|
function () use ($product): void {
|
||||||
$product->variants()->each(function (ProductVariant $variant): void {
|
|
||||||
$variant->clearMediaCollection('images');
|
|
||||||
});
|
|
||||||
$product->variants()->delete();
|
$product->variants()->delete();
|
||||||
$product->categories()->detach();
|
$product->categories()->detach();
|
||||||
$product->delete();
|
$product->delete();
|
||||||
@ -660,9 +656,6 @@ private function rejectCreate(OwnerVerificationRequest $verificationRequest): vo
|
|||||||
|
|
||||||
$this->runInTransaction(
|
$this->runInTransaction(
|
||||||
function () use ($product): void {
|
function () use ($product): void {
|
||||||
$product->variants()->each(function (ProductVariant $variant): void {
|
|
||||||
$variant->clearMediaCollection('images');
|
|
||||||
});
|
|
||||||
$product->variants()->delete();
|
$product->variants()->delete();
|
||||||
$product->categories()->detach();
|
$product->categories()->detach();
|
||||||
$product->delete();
|
$product->delete();
|
||||||
|
|||||||
@ -286,9 +286,6 @@ private function applyDeleteSubject(RawMaterial $rawMaterial): void
|
|||||||
{
|
{
|
||||||
$this->runInTransaction(
|
$this->runInTransaction(
|
||||||
function () use ($rawMaterial): void {
|
function () use ($rawMaterial): void {
|
||||||
$rawMaterial->prices()->each(function (RawMaterialPrice $price): void {
|
|
||||||
$price->clearMediaCollection('images');
|
|
||||||
});
|
|
||||||
$rawMaterial->prices()->delete();
|
$rawMaterial->prices()->delete();
|
||||||
$rawMaterial->delete();
|
$rawMaterial->delete();
|
||||||
},
|
},
|
||||||
@ -340,7 +337,6 @@ private function applyPayloadToRawMaterial(
|
|||||||
->whereNotIn('id', $submittedPriceIds)
|
->whereNotIn('id', $submittedPriceIds)
|
||||||
->get()
|
->get()
|
||||||
->each(function (RawMaterialPrice $price): void {
|
->each(function (RawMaterialPrice $price): void {
|
||||||
$price->clearMediaCollection('images');
|
|
||||||
$price->delete();
|
$price->delete();
|
||||||
});
|
});
|
||||||
|
|
||||||
@ -386,9 +382,6 @@ private function rejectCreate(OwnerVerificationRequest $verificationRequest): vo
|
|||||||
|
|
||||||
$this->runInTransaction(
|
$this->runInTransaction(
|
||||||
function () use ($rawMaterial): void {
|
function () use ($rawMaterial): void {
|
||||||
$rawMaterial->prices()->each(function (RawMaterialPrice $price): void {
|
|
||||||
$price->clearMediaCollection('images');
|
|
||||||
});
|
|
||||||
$rawMaterial->prices()->delete();
|
$rawMaterial->prices()->delete();
|
||||||
$rawMaterial->delete();
|
$rawMaterial->delete();
|
||||||
},
|
},
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user