refactor: remove unnecessary clearMediaCollection calls in various services to improve performance
This commit is contained in:
parent
ba01039b41
commit
a29e6af430
@ -283,7 +283,6 @@ function () use ($transaction): void {
|
||||
|
||||
$account = $transaction->cashAccount;
|
||||
|
||||
$transaction->clearMediaCollection('photos');
|
||||
$transaction->delete();
|
||||
|
||||
$this->recalculateBalances($account);
|
||||
|
||||
@ -133,7 +133,6 @@ function () use ($expense): void {
|
||||
$this->cashService->deleteReferencedTransaction($expense->cashTransaction);
|
||||
}
|
||||
|
||||
$expense->clearMediaCollection('photos');
|
||||
$expense->delete();
|
||||
},
|
||||
'Gagal menghapus pengeluaran',
|
||||
|
||||
@ -172,8 +172,6 @@ public function delete(Attendance $attendance, User $user): void
|
||||
|
||||
$this->runInTransaction(
|
||||
function () use ($attendance): void {
|
||||
$attendance->clearMediaCollection('checkin');
|
||||
$attendance->clearMediaCollection('checkout');
|
||||
$attendance->delete();
|
||||
},
|
||||
'Gagal menghapus presensi',
|
||||
|
||||
@ -680,7 +680,6 @@ function () use ($cutting): void {
|
||||
|
||||
$cutting->materials()->delete();
|
||||
$cutting->results()->delete();
|
||||
$cutting->clearMediaCollection('images');
|
||||
$cutting->delete();
|
||||
},
|
||||
'Gagal menghapus proses cutting',
|
||||
|
||||
@ -716,7 +716,6 @@ private function rejectCreate(OwnerVerificationRequest $verificationRequest): vo
|
||||
|
||||
$this->runInTransaction(
|
||||
function () use ($purchase): void {
|
||||
$purchase->clearMediaCollection('photos');
|
||||
$purchase->items()->delete();
|
||||
$purchase->delete();
|
||||
},
|
||||
@ -734,7 +733,6 @@ function () use ($purchase): void {
|
||||
$this->decrementStock($item);
|
||||
}
|
||||
|
||||
$purchase->clearMediaCollection('photos');
|
||||
$purchase->items()->delete();
|
||||
$purchase->delete();
|
||||
},
|
||||
|
||||
@ -573,7 +573,6 @@ private function rejectCreate(OwnerVerificationRequest $verificationRequest): vo
|
||||
|
||||
$this->runInTransaction(
|
||||
function () use ($restock): void {
|
||||
$restock->clearMediaCollection('photos');
|
||||
$restock->items()->delete();
|
||||
$restock->delete();
|
||||
},
|
||||
@ -593,7 +592,6 @@ function () use ($restock): void {
|
||||
$this->decrementStock($item, $stockType);
|
||||
}
|
||||
|
||||
$restock->clearMediaCollection('photos');
|
||||
$restock->items()->delete();
|
||||
$restock->delete();
|
||||
},
|
||||
|
||||
@ -523,7 +523,6 @@ private function applyPayloadToProduct(
|
||||
->whereNotIn('id', $submittedVariantIds)
|
||||
->get()
|
||||
->each(function (ProductVariant $variant): void {
|
||||
$variant->clearMediaCollection('images');
|
||||
$variant->delete();
|
||||
});
|
||||
|
||||
@ -590,9 +589,6 @@ private function applyDeleteSubject(Product $product): void
|
||||
{
|
||||
$this->runInTransaction(
|
||||
function () use ($product): void {
|
||||
$product->variants()->each(function (ProductVariant $variant): void {
|
||||
$variant->clearMediaCollection('images');
|
||||
});
|
||||
$product->variants()->delete();
|
||||
$product->categories()->detach();
|
||||
$product->delete();
|
||||
@ -660,9 +656,6 @@ private function rejectCreate(OwnerVerificationRequest $verificationRequest): vo
|
||||
|
||||
$this->runInTransaction(
|
||||
function () use ($product): void {
|
||||
$product->variants()->each(function (ProductVariant $variant): void {
|
||||
$variant->clearMediaCollection('images');
|
||||
});
|
||||
$product->variants()->delete();
|
||||
$product->categories()->detach();
|
||||
$product->delete();
|
||||
|
||||
@ -286,9 +286,6 @@ private function applyDeleteSubject(RawMaterial $rawMaterial): void
|
||||
{
|
||||
$this->runInTransaction(
|
||||
function () use ($rawMaterial): void {
|
||||
$rawMaterial->prices()->each(function (RawMaterialPrice $price): void {
|
||||
$price->clearMediaCollection('images');
|
||||
});
|
||||
$rawMaterial->prices()->delete();
|
||||
$rawMaterial->delete();
|
||||
},
|
||||
@ -340,7 +337,6 @@ private function applyPayloadToRawMaterial(
|
||||
->whereNotIn('id', $submittedPriceIds)
|
||||
->get()
|
||||
->each(function (RawMaterialPrice $price): void {
|
||||
$price->clearMediaCollection('images');
|
||||
$price->delete();
|
||||
});
|
||||
|
||||
@ -386,9 +382,6 @@ private function rejectCreate(OwnerVerificationRequest $verificationRequest): vo
|
||||
|
||||
$this->runInTransaction(
|
||||
function () use ($rawMaterial): void {
|
||||
$rawMaterial->prices()->each(function (RawMaterialPrice $price): void {
|
||||
$price->clearMediaCollection('images');
|
||||
});
|
||||
$rawMaterial->prices()->delete();
|
||||
$rawMaterial->delete();
|
||||
},
|
||||
|
||||
Loading…
Reference in New Issue
Block a user