refactor: streamline variant and price loading in product-related services

- Removed unnecessary ordering by 'created_at' in variant loading across multiple services and models.
- Implemented global scopes for ordering product variants and raw material prices by 'name' and 'variant', respectively.
- Enhanced code readability and maintainability by simplifying query structures in ProductController, OrderService, and others.

app/Http/Controllers/Admin/Master/ProductController.php

@@ -122,8 +122,7 @@ public function show(Product $product): JsonResponse
         $product->load([
             'categories',
             'variants' => fn ($query) => $query
-                ->with(['media', 'prices'])
-                ->orderBy('created_at'),
+                ->with(['media', 'prices']),
         ]);
 
         $product->variants->each(function ($variant): void {

app/Models/Product.php

@@ -97,8 +97,7 @@ public static function getActiveWithVariantsAndCategories(): Collection
             ->with([
                 'categories',
                 'variants' => fn ($query) => $query
-                    ->with('media')
-                    ->orderBy('created_at'),
+                    ->with('media'),
             ])
             ->get();
     }
@@ -123,6 +122,6 @@ public function pendingOwnerVerificationRequest(): MorphOne
 
     public function variants(): HasMany
     {
-        return $this->hasMany(ProductVariant::class);
+        return $this->hasMany(ProductVariant::class)->orderBy('name');
     }
 }

app/Models/ProductVariant.php

@@ -6,6 +6,7 @@
 use App\Models\Concerns\InteractsWithActivityLog;
 use Illuminate\Database\Eloquent\Attributes\Appends;
 use Illuminate\Database\Eloquent\Attributes\Guarded;
+use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Casts\Attribute;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
@@ -24,6 +25,13 @@ class ProductVariant extends Model implements HasMedia
 
     private const MIN_STOCK = 5;
 
+    protected static function booted(): void
+    {
+        static::addGlobalScope('ordered', function (Builder $query): void {
+            $query->orderBy('name');
+        });
+    }
+
     // 2. Casting
     protected function casts(): array
     {

app/Models/RawMaterial.php

@@ -107,6 +107,6 @@ public function pendingOwnerVerificationRequest(): MorphOne
 
     public function prices(): HasMany
     {
-        return $this->hasMany(RawMaterialPrice::class);
+        return $this->hasMany(RawMaterialPrice::class)->orderBy('variant');
     }
 }

app/Models/RawMaterialPrice.php

@@ -6,6 +6,7 @@
 use App\Models\Concerns\InteractsWithActivityLog;
 use Illuminate\Database\Eloquent\Attributes\Appends;
 use Illuminate\Database\Eloquent\Attributes\Guarded;
+use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Casts\Attribute;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
@@ -22,6 +23,13 @@ class RawMaterialPrice extends Model implements HasMedia
     // 1. Use Trait
     use HasFactory, HasModuleMedia, InteractsWithActivityLog, SoftDeletes;
 
+    protected static function booted(): void
+    {
+        static::addGlobalScope('ordered', function (Builder $query): void {
+            $query->orderBy('variant');
+        });
+    }
+
     // 2. Casting
     protected function casts(): array
     {

app/Services/Manage/OrderService.php

@@ -162,7 +162,6 @@ public function catalogItems(?Order $order = null, ?User $user = null): Collecti
             ->with([
                 'variants' => fn ($query) => $query
                     ->with('media')
-                    ->orderBy('created_at')
                     ->where(fn ($q) => $q
                         ->where('stock', '>', 0)
                         ->orWhere('reject_stock', '>', 0)

app/Services/Manage/RestockService.php

@@ -94,8 +94,7 @@ public function productCatalog(?Restock $restock = null, ?User $user = null): Co
         return Product::query()
             ->with([
                 'variants' => fn ($query) => $query
-                    ->with(['media', 'prices'])
-                    ->orderBy('created_at'),
+                    ->with(['media', 'prices']),
             ])
             ->where(function (Builder $query) use ($selectedVariantIds): void {
                 $query->active();

app/Services/Manage/StokOpnameService.php

@@ -59,8 +59,7 @@ public function catalogItems(): array
             ->active()
             ->with([
                 'variants' => fn ($query) => $query
-                    ->select('id', 'product_id', 'name', 'stock', 'retail_stock', 'reject_stock')
-                    ->orderBy('created_at'),
+                    ->select('id', 'product_id', 'name', 'stock', 'retail_stock', 'reject_stock'),
             ])
             ->orderBy('name')
             ->get()

app/Services/Master/ProductService.php

@@ -41,7 +41,6 @@ public function paginateForIndex(array $tableQuery, string $status, string $cate
                 'pendingOwnerVerificationRequest.submittedBy.profile',
                 'variants' => fn ($query) => $query
                     ->with(['media', 'prices' => fn ($query) => $query->orderBy('type')])
-                    ->orderBy('created_at')
                     ->when($tableQuery['search'] !== '', function ($query) use ($tableQuery): void {
                         $query->where('name', 'like', "%{$tableQuery['search']}%");
                     }),
@@ -113,8 +112,7 @@ public function findForEdit(Product $product): Product
         $product->load([
             'categories',
             'variants' => fn ($query) => $query
-                ->with(['media', 'prices'])
-                ->orderBy('created_at'),
+                ->with(['media', 'prices']),
         ]);
 
         $product->variants->each(function (ProductVariant $variant): void {