From 586ed448c722cbbbee4c3e2d0957cde5932460fd Mon Sep 17 00:00:00 2001
From: Yoga Pangestu <ypangestu976@gmail.com>
Date: Fri, 12 Jun 2026 16:41:22 +0700
Subject: [PATCH] Refactor AttendanceWebcamModal and LeaveRequestFormModal to
 streamline code and improve form handling. Update video and image display
 elements for consistency, and implement useFormDialog for better form
 management in LeaveRequestFormModal.

---
 .../hr/attendances/AttendanceWebcamModal.vue  | 39 +++++--------------
 .../leave-requests/LeaveRequestFormModal.vue  | 27 ++++++-------
 2 files changed, 20 insertions(+), 46 deletions(-)

diff --git a/resources/js/components/admin/hr/attendances/AttendanceWebcamModal.vue b/resources/js/components/admin/hr/attendances/AttendanceWebcamModal.vue
index b5eaf09..29dd82b 100644
--- a/resources/js/components/admin/hr/attendances/AttendanceWebcamModal.vue
+++ b/resources/js/components/admin/hr/attendances/AttendanceWebcamModal.vue
@@ -130,6 +130,7 @@ watch(open, async (isOpen) => {
         resetState();
         await nextTick();
         await initializeCamera();
+
         return;
     }
 
@@ -157,19 +158,11 @@ onBeforeUnmount(() => {
                     <p class="text-sm font-medium">
                         Kamera
                     </p>
-                    <div class="relative aspect-[4/3] overflow-hidden rounded-lg border bg-muted">
-                        <video
-                            ref="videoRef"
-                            class="size-full scale-x-[-1] object-cover"
-                            autoplay
-                            muted
-                            playsinline
-                        />
+                    <div class="relative aspect-4/3 overflow-hidden rounded-lg border bg-muted">
+                        <video ref="videoRef" class="size-full scale-x-[-1] object-cover" autoplay muted playsinline />
 
-                        <div
-                            v-if="cameraLoading"
-                            class="absolute inset-0 flex items-center justify-center bg-background/80"
-                        >
+                        <div v-if="cameraLoading"
+                            class="absolute inset-0 flex items-center justify-center bg-background/80">
                             <Loader2 class="text-muted-foreground size-8 animate-spin" />
                         </div>
                     </div>
@@ -179,12 +172,8 @@ onBeforeUnmount(() => {
                     <p class="text-sm font-medium">
                         Hasil Foto
                     </p>
-                    <div class="relative aspect-[4/3] overflow-hidden rounded-lg border bg-muted">
-                        <img
-                            :src="previewPhoto"
-                            alt="Hasil foto presensi"
-                            class="size-full object-cover"
-                        />
+                    <div class="relative aspect-4/3 overflow-hidden rounded-lg border bg-muted">
+                        <img :src="previewPhoto" alt="Hasil foto presensi" class="size-full object-cover" />
                     </div>
 
                     <p class="text-muted-foreground text-xs whitespace-pre-line">
@@ -198,23 +187,13 @@ onBeforeUnmount(() => {
                     Ambil Ulang
                 </Button>
 
-                <Button
-                    v-if="!previewPhoto"
-                    type="button"
-                    :disabled="!cameraReady || capturing"
-                    @click="capturePhoto"
-                >
+                <Button v-if="!previewPhoto" type="button" :disabled="!cameraReady || capturing" @click="capturePhoto">
                     <Loader2 v-if="capturing" class="size-4 animate-spin" />
                     <Camera v-else class="size-4" />
                     Ambil Foto
                 </Button>
 
-                <Button
-                    v-else
-                    type="button"
-                    :disabled="form.processing"
-                    @click="submitAttendance"
-                >
+                <Button v-else type="button" :disabled="form.processing" @click="submitAttendance">
                     <Loader2 v-if="form.processing" class="size-4 animate-spin" />
                     {{ submitLabel }}
                 </Button>
diff --git a/resources/js/components/admin/hr/leave-requests/LeaveRequestFormModal.vue b/resources/js/components/admin/hr/leave-requests/LeaveRequestFormModal.vue
index 4b2aff1..a271e78 100644
--- a/resources/js/components/admin/hr/leave-requests/LeaveRequestFormModal.vue
+++ b/resources/js/components/admin/hr/leave-requests/LeaveRequestFormModal.vue
@@ -1,7 +1,7 @@
 <script setup lang="ts">
 import { useForm } from '@inertiajs/vue3';
 import { Save } from '@lucide/vue';
-import { computed, watch } from 'vue';
+import { computed } from 'vue';
 import { toast } from 'vue-sonner';
 import { Button } from '@/components/ui/button';
 import { DatePicker } from '@/components/ui/date-picker';
@@ -19,6 +19,7 @@ import {
     FieldLabel,
     FieldSet,
 } from '@/components/ui/field';
+import { useFormDialog } from '@/composables/useFormDialog';
 import { formErrors } from '@/lib/form';
 import type { LeaveRequestFormData, LeaveRequestListItem } from '@/types/leave-request';
 
@@ -51,19 +52,11 @@ function populateForm(leaveRequest: LeaveRequestListItem | null | undefined) {
     form.end_date = leaveRequest.end_date_input;
 }
 
-watch(
-    () => props.leaveRequest,
-    (leaveRequest) => {
-        populateForm(leaveRequest);
-    },
-);
-
-watch(open, (isOpen) => {
-    if (isOpen) {
-        populateForm(props.leaveRequest);
-    } else {
-        resetForm();
-    }
+useFormDialog({
+    open,
+    source: () => props.leaveRequest,
+    populate: populateForm,
+    reset: resetForm,
 });
 
 function submit() {
@@ -79,9 +72,11 @@ function submit() {
 
     if (isEditing.value && props.leaveRequest) {
         form.put(`/admin/hr/leave-requests/${props.leaveRequest.id}`, options);
-    } else {
-        form.post('/admin/hr/leave-requests', options);
+
+        return;
     }
+
+    form.post('/admin/hr/leave-requests', options);
 }
 </script>