From fc1c84f420d9f551a13aec1c56d9399ad586f84a Mon Sep 17 00:00:00 2001 From: Yoga Pangestu Date: Wed, 5 Aug 2026 22:35:46 +0700 Subject: [PATCH] refactor: remove readonly modifier from S3PresignedService property for consistency --- app/Http/Controllers/Admin/AdminSettingsController.php | 2 +- .../Controllers/Admin/Finance/CashAccountController.php | 2 +- .../Controllers/Admin/Finance/EmployeeAdvanceController.php | 2 +- app/Http/Controllers/Admin/Finance/ExpenseController.php | 2 +- .../Admin/Finance/PayrollAdjustmentController.php | 4 ++-- app/Http/Controllers/Admin/Finance/PayrollController.php | 2 +- .../Controllers/Admin/Finance/PayrollPeriodController.php | 2 +- app/Http/Controllers/Admin/HR/AttendanceController.php | 2 +- app/Http/Controllers/Admin/HR/EmployeeController.php | 2 +- app/Http/Controllers/Admin/HR/LeaveRequestController.php | 2 +- app/Http/Controllers/Admin/Manage/CuttingController.php | 2 +- app/Http/Controllers/Admin/Manage/PurchaseController.php | 2 +- app/Http/Controllers/Admin/Manage/RestockController.php | 2 +- app/Http/Controllers/Admin/Manage/TransactionController.php | 2 +- app/Http/Controllers/Admin/Master/CategoryController.php | 2 +- app/Http/Controllers/Admin/Master/CustomerController.php | 2 +- .../Controllers/Admin/Master/Product/ProductController.php | 4 ++-- .../Admin/Master/Product/ProductVariantController.php | 2 +- .../Admin/Master/Product/StockMutationController.php | 2 +- .../Admin/Master/RawMaterial/RawMaterialController.php | 2 +- .../Master/RawMaterial/RawMaterialVariantController.php | 2 +- app/Http/Controllers/Admin/Master/SupplierController.php | 2 +- app/Http/Controllers/Admin/RoleController.php | 2 +- app/Http/Controllers/Api/PresignedUrlController.php | 2 +- app/Http/Controllers/Api/PushSubscriptionController.php | 2 +- app/Services/Admin/AdminSettingsService.php | 2 +- app/Services/Admin/Finance/CashAccountService.php | 2 +- app/Services/Admin/Finance/ExpenseService.php | 2 +- app/Services/Admin/HR/AttendanceService.php | 2 +- app/Services/Admin/Manage/CuttingService.php | 2 +- app/Services/Admin/Manage/PurchaseService.php | 2 +- app/Services/Admin/Manage/RestockService.php | 2 +- app/Services/Admin/Manage/TransactionService.php | 2 +- app/Services/Admin/Master/Product/ProductService.php | 6 +++--- app/Services/Admin/Master/Product/ProductVariantService.php | 4 ++-- .../Admin/Master/RawMaterial/RawMaterialService.php | 2 +- .../Admin/Master/RawMaterial/RawMaterialVariantService.php | 2 +- database/seeders/RolePermissionSeeder.php | 2 +- 38 files changed, 43 insertions(+), 43 deletions(-) diff --git a/app/Http/Controllers/Admin/AdminSettingsController.php b/app/Http/Controllers/Admin/AdminSettingsController.php index 958bce3..e43fd43 100644 --- a/app/Http/Controllers/Admin/AdminSettingsController.php +++ b/app/Http/Controllers/Admin/AdminSettingsController.php @@ -16,7 +16,7 @@ class AdminSettingsController extends Controller { public function __construct( - private readonly AdminSettingsService $service + private AdminSettingsService $service ) {} public function index(): Response diff --git a/app/Http/Controllers/Admin/Finance/CashAccountController.php b/app/Http/Controllers/Admin/Finance/CashAccountController.php index 9fcf7e1..d329fb1 100644 --- a/app/Http/Controllers/Admin/Finance/CashAccountController.php +++ b/app/Http/Controllers/Admin/Finance/CashAccountController.php @@ -15,7 +15,7 @@ class CashAccountController extends Controller { public function __construct( - private readonly CashAccountService $service + private CashAccountService $service ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/Finance/EmployeeAdvanceController.php b/app/Http/Controllers/Admin/Finance/EmployeeAdvanceController.php index f655e76..1031240 100644 --- a/app/Http/Controllers/Admin/Finance/EmployeeAdvanceController.php +++ b/app/Http/Controllers/Admin/Finance/EmployeeAdvanceController.php @@ -14,7 +14,7 @@ class EmployeeAdvanceController extends Controller { public function __construct( - private readonly EmployeeAdvanceService $service + private EmployeeAdvanceService $service ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/Finance/ExpenseController.php b/app/Http/Controllers/Admin/Finance/ExpenseController.php index 322c931..47f9244 100644 --- a/app/Http/Controllers/Admin/Finance/ExpenseController.php +++ b/app/Http/Controllers/Admin/Finance/ExpenseController.php @@ -14,7 +14,7 @@ class ExpenseController extends Controller { public function __construct( - private readonly ExpenseService $service + private ExpenseService $service ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/Finance/PayrollAdjustmentController.php b/app/Http/Controllers/Admin/Finance/PayrollAdjustmentController.php index 069cb77..a828e83 100644 --- a/app/Http/Controllers/Admin/Finance/PayrollAdjustmentController.php +++ b/app/Http/Controllers/Admin/Finance/PayrollAdjustmentController.php @@ -12,7 +12,7 @@ class PayrollAdjustmentController extends Controller { public function __construct( - private readonly PayrollAdjustmentService $service + private PayrollAdjustmentService $service ) {} public function store(PayrollAdjustmentRequest $request, Payroll $payroll): RedirectResponse @@ -21,7 +21,7 @@ public function store(PayrollAdjustmentRequest $request, Payroll $payroll): Redi fn () => $this->service->create($payroll, $request->validated()), 'Adjustment gaji berhasil ditambahkan.', 'admin.finance.payroll-periods.show', - parameters : ['payroll_period' => $payroll->payroll_period_id] + parameters: ['payroll_period' => $payroll->payroll_period_id] ); } diff --git a/app/Http/Controllers/Admin/Finance/PayrollController.php b/app/Http/Controllers/Admin/Finance/PayrollController.php index 98cbefb..5ef7549 100644 --- a/app/Http/Controllers/Admin/Finance/PayrollController.php +++ b/app/Http/Controllers/Admin/Finance/PayrollController.php @@ -10,7 +10,7 @@ class PayrollController extends Controller { public function __construct( - private readonly PayrollPeriodService $service + private PayrollPeriodService $service ) {} public function pay(Payroll $payroll): RedirectResponse diff --git a/app/Http/Controllers/Admin/Finance/PayrollPeriodController.php b/app/Http/Controllers/Admin/Finance/PayrollPeriodController.php index 7d8851e..4e00b67 100644 --- a/app/Http/Controllers/Admin/Finance/PayrollPeriodController.php +++ b/app/Http/Controllers/Admin/Finance/PayrollPeriodController.php @@ -14,7 +14,7 @@ class PayrollPeriodController extends Controller { public function __construct( - private readonly PayrollPeriodService $service + private PayrollPeriodService $service ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/HR/AttendanceController.php b/app/Http/Controllers/Admin/HR/AttendanceController.php index 93af584..438782c 100644 --- a/app/Http/Controllers/Admin/HR/AttendanceController.php +++ b/app/Http/Controllers/Admin/HR/AttendanceController.php @@ -15,7 +15,7 @@ class AttendanceController extends Controller { public function __construct( - private readonly AttendanceService $service + private AttendanceService $service ) {} public function index(Request $request): Response diff --git a/app/Http/Controllers/Admin/HR/EmployeeController.php b/app/Http/Controllers/Admin/HR/EmployeeController.php index 3b42e8f..baf90af 100644 --- a/app/Http/Controllers/Admin/HR/EmployeeController.php +++ b/app/Http/Controllers/Admin/HR/EmployeeController.php @@ -15,7 +15,7 @@ class EmployeeController extends Controller { public function __construct( - private readonly EmployeeService $service + private EmployeeService $service ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/HR/LeaveRequestController.php b/app/Http/Controllers/Admin/HR/LeaveRequestController.php index 22e6717..1d78c86 100644 --- a/app/Http/Controllers/Admin/HR/LeaveRequestController.php +++ b/app/Http/Controllers/Admin/HR/LeaveRequestController.php @@ -15,7 +15,7 @@ class LeaveRequestController extends Controller { public function __construct( - private readonly LeaveRequestService $service + private LeaveRequestService $service ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/Manage/CuttingController.php b/app/Http/Controllers/Admin/Manage/CuttingController.php index 5fdd21b..1ea9f12 100644 --- a/app/Http/Controllers/Admin/Manage/CuttingController.php +++ b/app/Http/Controllers/Admin/Manage/CuttingController.php @@ -14,7 +14,7 @@ class CuttingController extends Controller { public function __construct( - private readonly CuttingService $service, + private CuttingService $service, ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/Manage/PurchaseController.php b/app/Http/Controllers/Admin/Manage/PurchaseController.php index f17091c..66de86e 100644 --- a/app/Http/Controllers/Admin/Manage/PurchaseController.php +++ b/app/Http/Controllers/Admin/Manage/PurchaseController.php @@ -14,7 +14,7 @@ class PurchaseController extends Controller { public function __construct( - private readonly PurchaseService $service, + private PurchaseService $service, ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/Manage/RestockController.php b/app/Http/Controllers/Admin/Manage/RestockController.php index 96b7c1e..b0b94f9 100644 --- a/app/Http/Controllers/Admin/Manage/RestockController.php +++ b/app/Http/Controllers/Admin/Manage/RestockController.php @@ -14,7 +14,7 @@ class RestockController extends Controller { public function __construct( - private readonly RestockService $service, + private RestockService $service, ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/Manage/TransactionController.php b/app/Http/Controllers/Admin/Manage/TransactionController.php index 009c20a..d2312a0 100644 --- a/app/Http/Controllers/Admin/Manage/TransactionController.php +++ b/app/Http/Controllers/Admin/Manage/TransactionController.php @@ -14,7 +14,7 @@ class TransactionController extends Controller { public function __construct( - private readonly TransactionService $service, + private TransactionService $service, ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/Master/CategoryController.php b/app/Http/Controllers/Admin/Master/CategoryController.php index 4a5b413..417e160 100644 --- a/app/Http/Controllers/Admin/Master/CategoryController.php +++ b/app/Http/Controllers/Admin/Master/CategoryController.php @@ -14,7 +14,7 @@ class CategoryController extends Controller { public function __construct( - private readonly CategoryService $service + private CategoryService $service ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/Master/CustomerController.php b/app/Http/Controllers/Admin/Master/CustomerController.php index e5d3358..e660dbd 100644 --- a/app/Http/Controllers/Admin/Master/CustomerController.php +++ b/app/Http/Controllers/Admin/Master/CustomerController.php @@ -14,7 +14,7 @@ class CustomerController extends Controller { public function __construct( - private readonly CustomerService $service + private CustomerService $service ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/Master/Product/ProductController.php b/app/Http/Controllers/Admin/Master/Product/ProductController.php index f5765ea..fe09732 100644 --- a/app/Http/Controllers/Admin/Master/Product/ProductController.php +++ b/app/Http/Controllers/Admin/Master/Product/ProductController.php @@ -15,8 +15,8 @@ class ProductController extends Controller { public function __construct( - private readonly ProductService $service, - private readonly CategoryService $categoryService, + private ProductService $service, + private CategoryService $categoryService, ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/Master/Product/ProductVariantController.php b/app/Http/Controllers/Admin/Master/Product/ProductVariantController.php index ed10bcf..c334947 100644 --- a/app/Http/Controllers/Admin/Master/Product/ProductVariantController.php +++ b/app/Http/Controllers/Admin/Master/Product/ProductVariantController.php @@ -15,7 +15,7 @@ class ProductVariantController extends Controller { public function __construct( - private readonly ProductVariantService $variantService, + private ProductVariantService $variantService, ) {} public function edit(Product $product, ProductVariant $variant): Response diff --git a/app/Http/Controllers/Admin/Master/Product/StockMutationController.php b/app/Http/Controllers/Admin/Master/Product/StockMutationController.php index e8a07a5..eaaa7ad 100644 --- a/app/Http/Controllers/Admin/Master/Product/StockMutationController.php +++ b/app/Http/Controllers/Admin/Master/Product/StockMutationController.php @@ -13,7 +13,7 @@ class StockMutationController extends Controller { public function __construct( - private readonly StockMutationService $service, + private StockMutationService $service, ) {} public function index(StockMutationRequest $request, Product $product, ProductVariant $variant): Response diff --git a/app/Http/Controllers/Admin/Master/RawMaterial/RawMaterialController.php b/app/Http/Controllers/Admin/Master/RawMaterial/RawMaterialController.php index 73f1a89..52135f8 100644 --- a/app/Http/Controllers/Admin/Master/RawMaterial/RawMaterialController.php +++ b/app/Http/Controllers/Admin/Master/RawMaterial/RawMaterialController.php @@ -14,7 +14,7 @@ class RawMaterialController extends Controller { public function __construct( - private readonly RawMaterialService $service, + private RawMaterialService $service, ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/Master/RawMaterial/RawMaterialVariantController.php b/app/Http/Controllers/Admin/Master/RawMaterial/RawMaterialVariantController.php index 4947526..64920a2 100644 --- a/app/Http/Controllers/Admin/Master/RawMaterial/RawMaterialVariantController.php +++ b/app/Http/Controllers/Admin/Master/RawMaterial/RawMaterialVariantController.php @@ -14,7 +14,7 @@ class RawMaterialVariantController extends Controller { public function __construct( - private readonly RawMaterialVariantService $variantService, + private RawMaterialVariantService $variantService, ) {} public function edit(RawMaterial $rawMaterial, RawMaterialPrice $variant): Response diff --git a/app/Http/Controllers/Admin/Master/SupplierController.php b/app/Http/Controllers/Admin/Master/SupplierController.php index 9342dd2..eed93c9 100644 --- a/app/Http/Controllers/Admin/Master/SupplierController.php +++ b/app/Http/Controllers/Admin/Master/SupplierController.php @@ -14,7 +14,7 @@ class SupplierController extends Controller { public function __construct( - private readonly SupplierService $service + private SupplierService $service ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Admin/RoleController.php b/app/Http/Controllers/Admin/RoleController.php index e20d82c..11b29ff 100644 --- a/app/Http/Controllers/Admin/RoleController.php +++ b/app/Http/Controllers/Admin/RoleController.php @@ -14,7 +14,7 @@ class RoleController extends Controller { public function __construct( - private readonly RoleService $service + private RoleService $service ) {} public function index(PaginatedRequest $request): Response diff --git a/app/Http/Controllers/Api/PresignedUrlController.php b/app/Http/Controllers/Api/PresignedUrlController.php index 96a0c53..1d8904f 100644 --- a/app/Http/Controllers/Api/PresignedUrlController.php +++ b/app/Http/Controllers/Api/PresignedUrlController.php @@ -11,7 +11,7 @@ class PresignedUrlController extends Controller { public function __construct( - private readonly S3PresignedService $service + private S3PresignedService $service ) {} public function store(PresignedUrlRequest $request): JsonResponse diff --git a/app/Http/Controllers/Api/PushSubscriptionController.php b/app/Http/Controllers/Api/PushSubscriptionController.php index 5e426f4..e13806a 100644 --- a/app/Http/Controllers/Api/PushSubscriptionController.php +++ b/app/Http/Controllers/Api/PushSubscriptionController.php @@ -11,7 +11,7 @@ class PushSubscriptionController extends Controller { public function __construct( - private readonly PushSubscriptionService $service, + private PushSubscriptionService $service, ) {} public function store(StorePushSubscriptionRequest $request): JsonResponse diff --git a/app/Services/Admin/AdminSettingsService.php b/app/Services/Admin/AdminSettingsService.php index 5b184a6..bd9ae3d 100644 --- a/app/Services/Admin/AdminSettingsService.php +++ b/app/Services/Admin/AdminSettingsService.php @@ -13,7 +13,7 @@ class AdminSettingsService { public function __construct( - private readonly S3PresignedService $s3Service, + private S3PresignedService $s3Service, ) {} public function getSystemData(): array diff --git a/app/Services/Admin/Finance/CashAccountService.php b/app/Services/Admin/Finance/CashAccountService.php index 2634994..c3d6023 100644 --- a/app/Services/Admin/Finance/CashAccountService.php +++ b/app/Services/Admin/Finance/CashAccountService.php @@ -20,7 +20,7 @@ class CashAccountService use HandlesCashTransactions, RegistersMedia; public function __construct( - private readonly S3PresignedService $s3Service, + private S3PresignedService $s3Service, ) {} public function get(): ?CashAccount diff --git a/app/Services/Admin/Finance/ExpenseService.php b/app/Services/Admin/Finance/ExpenseService.php index 9d2ddfa..c0b86b9 100644 --- a/app/Services/Admin/Finance/ExpenseService.php +++ b/app/Services/Admin/Finance/ExpenseService.php @@ -19,7 +19,7 @@ class ExpenseService use HandlesCashTransactions, RegistersMedia; public function __construct( - private readonly S3PresignedService $s3Service, + private S3PresignedService $s3Service, ) {} public function getAll(array $filters = []): Collection diff --git a/app/Services/Admin/HR/AttendanceService.php b/app/Services/Admin/HR/AttendanceService.php index 43279a9..513f8c4 100644 --- a/app/Services/Admin/HR/AttendanceService.php +++ b/app/Services/Admin/HR/AttendanceService.php @@ -16,7 +16,7 @@ class AttendanceService use RegistersMedia; public function __construct( - private readonly S3PresignedService $s3Service, + private S3PresignedService $s3Service, ) {} public function getAll(): Collection diff --git a/app/Services/Admin/Manage/CuttingService.php b/app/Services/Admin/Manage/CuttingService.php index 0b32f88..988ba18 100644 --- a/app/Services/Admin/Manage/CuttingService.php +++ b/app/Services/Admin/Manage/CuttingService.php @@ -19,7 +19,7 @@ class CuttingService use RegistersMedia; public function __construct( - private readonly S3PresignedService $s3Service, + private S3PresignedService $s3Service, ) {} public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator diff --git a/app/Services/Admin/Manage/PurchaseService.php b/app/Services/Admin/Manage/PurchaseService.php index 2e026a0..3a03eb2 100644 --- a/app/Services/Admin/Manage/PurchaseService.php +++ b/app/Services/Admin/Manage/PurchaseService.php @@ -18,7 +18,7 @@ class PurchaseService use RegistersMedia; public function __construct( - private readonly S3PresignedService $s3Service, + private S3PresignedService $s3Service, ) {} public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator diff --git a/app/Services/Admin/Manage/RestockService.php b/app/Services/Admin/Manage/RestockService.php index bfd89c3..a515827 100644 --- a/app/Services/Admin/Manage/RestockService.php +++ b/app/Services/Admin/Manage/RestockService.php @@ -20,7 +20,7 @@ class RestockService use HasStockAdjustment, RegistersMedia; public function __construct( - private readonly S3PresignedService $s3Service, + private S3PresignedService $s3Service, ) {} public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator diff --git a/app/Services/Admin/Manage/TransactionService.php b/app/Services/Admin/Manage/TransactionService.php index 40c1493..9407686 100644 --- a/app/Services/Admin/Manage/TransactionService.php +++ b/app/Services/Admin/Manage/TransactionService.php @@ -35,7 +35,7 @@ class TransactionService ]; public function __construct( - private readonly S3PresignedService $s3Service, + private S3PresignedService $s3Service, ) {} public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc', array $filters = []): LengthAwarePaginator diff --git a/app/Services/Admin/Master/Product/ProductService.php b/app/Services/Admin/Master/Product/ProductService.php index 7a9d557..0504150 100644 --- a/app/Services/Admin/Master/Product/ProductService.php +++ b/app/Services/Admin/Master/Product/ProductService.php @@ -14,9 +14,9 @@ class ProductService { public function __construct( - private readonly ProductVariantService $variantService, - private readonly S3PresignedService $s3Service, - private readonly StockMutationService $stockMutationService, + private ProductVariantService $variantService, + private S3PresignedService $s3Service, + private StockMutationService $stockMutationService, ) {} public function getAll(array $filters = []): Collection diff --git a/app/Services/Admin/Master/Product/ProductVariantService.php b/app/Services/Admin/Master/Product/ProductVariantService.php index 57468cb..2d32a99 100644 --- a/app/Services/Admin/Master/Product/ProductVariantService.php +++ b/app/Services/Admin/Master/Product/ProductVariantService.php @@ -16,8 +16,8 @@ class ProductVariantService use RegistersMedia; public function __construct( - private readonly S3PresignedService $s3Service, - private readonly StockMutationService $stockMutationService, + private S3PresignedService $s3Service, + private StockMutationService $stockMutationService, ) {} public function getForEdit(ProductVariant $variant): array diff --git a/app/Services/Admin/Master/RawMaterial/RawMaterialService.php b/app/Services/Admin/Master/RawMaterial/RawMaterialService.php index deb22fc..9c97b86 100644 --- a/app/Services/Admin/Master/RawMaterial/RawMaterialService.php +++ b/app/Services/Admin/Master/RawMaterial/RawMaterialService.php @@ -15,7 +15,7 @@ class RawMaterialService use RegistersMedia; public function __construct( - private readonly S3PresignedService $s3Service, + private S3PresignedService $s3Service, ) {} public function getAll(array $filters = []): Collection diff --git a/app/Services/Admin/Master/RawMaterial/RawMaterialVariantService.php b/app/Services/Admin/Master/RawMaterial/RawMaterialVariantService.php index 5fed5dc..813a36d 100644 --- a/app/Services/Admin/Master/RawMaterial/RawMaterialVariantService.php +++ b/app/Services/Admin/Master/RawMaterial/RawMaterialVariantService.php @@ -14,7 +14,7 @@ class RawMaterialVariantService use RegistersMedia; public function __construct( - private readonly S3PresignedService $s3Service, + private S3PresignedService $s3Service, ) {} public function getForEdit(RawMaterialPrice $variant): array diff --git a/database/seeders/RolePermissionSeeder.php b/database/seeders/RolePermissionSeeder.php index c96b853..84cf281 100644 --- a/database/seeders/RolePermissionSeeder.php +++ b/database/seeders/RolePermissionSeeder.php @@ -253,7 +253,7 @@ public function run(): void 'stocks.view', 'owner_verifications.view', - + 'cuttings.view', 'cuttings.create', 'cuttings.update',