refactor: standardize pagination parameters and improve code formatting across multiple services

This commit is contained in:
Yoga Pangestu 2026-08-01 22:51:24 +07:00
parent a53fe3c2fd
commit d943c3a240
11 changed files with 15 additions and 13 deletions

View File

@ -46,7 +46,7 @@ public function getAllTransactions(array $filters = []): Collection
->map(fn (CashTransaction $transaction) => $this->formatTransaction($transaction));
}
public function paginatedTransactions(int $perPage = 15, string $search = '', string $sort = 'created_at', string $direction = 'desc', array $filters = []): LengthAwarePaginator
public function paginatedTransactions(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc', array $filters = []): LengthAwarePaginator
{
$cashAccount = $this->get();

View File

@ -23,7 +23,7 @@ public function getAll(): Collection
->get();
}
public function paginated(int $perPage = 15, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
{
return EmployeeAdvance::query()
->select('id', 'employee_id', 'amount', 'paid_amount', 'description', 'due_date', 'status', 'created_at')

View File

@ -32,7 +32,7 @@ public function getAll(): Collection
->map(fn (Expense $expense) => $this->formatExpense($expense));
}
public function paginated(int $perPage = 15, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
{
$paginator = Expense::query()
->select('id', 'created_by_id', 'amount', 'description', 'created_at')

View File

@ -35,7 +35,7 @@ public function getAll(): Collection
->get();
}
public function paginated(int $perPage = 15, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
{
return PayrollPeriod::query()
->select('id', 'year', 'month', 'status', 'closed_at', 'created_at')

View File

@ -24,7 +24,7 @@ public function getAll(array $filters = []): Collection
->get();
}
public function paginated(int $perPage = 15, string $search = '', string $sort = 'created_at', string $direction = 'desc', array $filters = []): LengthAwarePaginator
public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc', array $filters = []): LengthAwarePaginator
{
return User::query()
->select('id', 'email', 'username', 'is_active')

View File

@ -23,7 +23,7 @@ public function getAll(array $filters = []): Collection
->get();
}
public function paginated(int $perPage = 15, string $search = '', string $sort = 'created_at', string $direction = 'desc', array $filters = []): LengthAwarePaginator
public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc', array $filters = []): LengthAwarePaginator
{
return LeaveRequest::query()
->select('id', 'employee_id', 'start_date', 'end_date', 'total_days', 'status', 'created_at')

View File

@ -13,7 +13,7 @@ public function getAll(): Collection
return Category::select('id', 'name')->latest()->get();
}
public function paginated(int $perPage = 15, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
{
return Category::query()
->select('id', 'name')

View File

@ -13,7 +13,7 @@ public function getAll(): Collection
return Customer::select('id', 'name', 'phone_number', 'address')->latest()->get();
}
public function paginated(int $perPage = 15, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
{
return Customer::query()
->select('id', 'name', 'phone_number', 'address')

View File

@ -43,7 +43,7 @@ public function getAll(array $filters = []): Collection
return $products;
}
public function paginated(int $perPage = 15, string $search = '', string $sort = 'created_at', string $direction = 'desc', array $filters = []): LengthAwarePaginator
public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc', array $filters = []): LengthAwarePaginator
{
$paginator = Product::query()
->select('id', 'name', 'slug', 'description', 'status')
@ -242,10 +242,12 @@ public function update(Product $product, array $data): Product
$variant = $existingVariantsMap[$variantId];
$oldStockDataMap[$variantId] = $variant->only(['stock', 'reject_stock', 'retail_stock']);
if ($variant->name !== $variantData['name']
if (
$variant->name !== $variantData['name']
|| $variant->stock != $variantData['stock']
|| $variant->reject_stock != $variantData['reject_stock']
|| $variant->retail_stock != $variantData['retail_stock']) {
|| $variant->retail_stock != $variantData['retail_stock']
) {
$changedIds[] = $variantId;
}
}

View File

@ -13,7 +13,7 @@ public function getAll(): Collection
return Supplier::select('id', 'name', 'phone_number', 'address')->latest()->get();
}
public function paginated(int $perPage = 15, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
{
return Supplier::query()
->select('id', 'name', 'phone_number', 'address')

View File

@ -15,7 +15,7 @@ public function getAll(): Collection
return Role::withCount('permissions')->get();
}
public function paginated(int $perPage = 15, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc'): LengthAwarePaginator
{
return Role::query()
->withCount('permissions')