dst/dstpabuaran.com
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: refactor getForRestock and getForTransaction methods to improve media handling and streamline data retrieval

Browse Source
This commit is contained in:
Yoga Pangestu 2026-08-15 14:59:06 +07:00
parent 0d1e6ba1fe
commit 41a32b08f2
1 changed files with 57 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
app/Services/Admin/Master/Product/ProductVariantService.php
View File

@ -14,6 +14,7 @@
use App\Services\StockMutationService;
use Illuminate\Support\Facades\DB;
use Illuminate\Validation\ValidationException;
use Spatie\MediaLibrary\MediaCollections\Models\Media;
class ProductVariantService
{
@ -26,7 +27,7 @@ public function __construct(
public function getForRestock(): array
{
return Product::query()
$products = Product::query()
->select(['id', 'name', 'status'])
->with([
'productVariants:id,product_id,name,stock,reject_stock',
@ -34,10 +35,24 @@ public function getForRestock(): array
])
->active()
->orderBy('name')
->get();
$allVariantIds = $products->pluck('productVariants.*.id')->flatten()->filter()->all();
if ($allVariantIds !== []) {
$mediaByVariant = Media::query()
->whereIn('mediable_id', $allVariantIds)
->where('mediable_type', ProductVariant::class)
->where('collection_name', 'images')
->get()
->each(function (Product $product) {
$product->productVariants->each(function (ProductVariant $variant) {
$media = $variant->getFirstMedia('images');
->groupBy('mediable_id');
} else {
$mediaByVariant = collect();
}
return $products->each(function (Product $product) use ($mediaByVariant) {
$product->productVariants->each(function (ProductVariant $variant) use ($mediaByVariant) {
$media = $mediaByVariant->get($variant->id, collect())->first();
$variant->photo_url = $media
? $this->s3Service->getTemporaryUrl($media->getPath())
: null;
@ -55,7 +70,7 @@ public function getForRestock(): array
public function getForTransaction(): array
{
return Product::query()
$products = Product::query()
->select(['id', 'name', 'status'])
->with([
'productVariants:id,product_id,name,stock,reject_stock',
@ -63,10 +78,24 @@ public function getForTransaction(): array
])
->active()
->orderBy('name')
->get();
$allVariantIds = $products->pluck('productVariants.*.id')->flatten()->filter()->all();
if ($allVariantIds !== []) {
$mediaByVariant = Media::query()
->whereIn('mediable_id', $allVariantIds)
->where('mediable_type', ProductVariant::class)
->where('collection_name', 'images')
->get()
->each(function (Product $product) {
$product->productVariants->each(function (ProductVariant $variant) {
$media = $variant->getFirstMedia('images');
->groupBy('mediable_id');
} else {
$mediaByVariant = collect();
}
return $products->each(function (Product $product) use ($mediaByVariant) {
$product->productVariants->each(function (ProductVariant $variant) use ($mediaByVariant) {
$media = $mediaByVariant->get($variant->id, collect())->first();
$variant->photo_url = $media
? $this->s3Service->getTemporaryUrl($media->getPath())
: null;