dst/dstpabuaran.com
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: improve formatting consistency in various models and services

Browse Source
This commit is contained in:
Yoga Pangestu 2026-08-05 20:27:27 +07:00
parent b70a40af4d
commit 3f77a9436d
28 changed files with 61 additions and 67 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/Services/Admin/Finance/EmployeeAdvanceService.php
View File

@ -2,10 +2,8 @@
namespace App\Services\Admin\Finance; namespace App\Services\Admin\Finance;
use App\Enums\CashTransactionType;
use App\Enums\EmployeeAdvanceStatus; use App\Enums\EmployeeAdvanceStatus;
use App\Models\CashAccount; use App\Models\CashAccount;
use App\Models\CashTransaction;
use App\Models\EmployeeAdvance; use App\Models\EmployeeAdvance;
use App\Services\Concerns\HandlesCashTransactions; use App\Services\Concerns\HandlesCashTransactions;
use App\Services\NotificationService; use App\Services\NotificationService;
@ -17,6 +15,7 @@
class EmployeeAdvanceService class EmployeeAdvanceService
{ {
use HandlesCashTransactions; use HandlesCashTransactions;
public function getAll(array $filters = []): Collection public function getAll(array $filters = []): Collection
{ {
return EmployeeAdvance::select('id', 'employee_id', 'amount', 'paid_amount', 'description', 'due_date', 'status', 'created_at') return EmployeeAdvance::select('id', 'employee_id', 'amount', 'paid_amount', 'description', 'due_date', 'status', 'created_at')

2
app/Services/Admin/Finance/ExpenseService.php
View File

@ -2,9 +2,7 @@
namespace App\Services\Admin\Finance; namespace App\Services\Admin\Finance;
use App\Enums\CashTransactionType;
use App\Models\CashAccount; use App\Models\CashAccount;
use App\Models\CashTransaction;
use App\Models\Expense; use App\Models\Expense;
use App\Services\Concerns\HandlesCashTransactions; use App\Services\Concerns\HandlesCashTransactions;
use App\Services\Concerns\RegistersMedia; use App\Services\Concerns\RegistersMedia;

4
app/Services/Admin/Finance/PayrollPeriodService.php
View File

@ -2,11 +2,8 @@
namespace App\Services\Admin\Finance; namespace App\Services\Admin\Finance;
use App\Enums\CashTransactionType;
use App\Enums\PayrollPeriodStatus; use App\Enums\PayrollPeriodStatus;
use App\Enums\PayrollStatus; use App\Enums\PayrollStatus;
use App\Models\CashAccount;
use App\Models\CashTransaction;
use App\Models\Payroll; use App\Models\Payroll;
use App\Models\PayrollPeriod; use App\Models\PayrollPeriod;
use App\Services\Concerns\HandlesCashTransactions; use App\Services\Concerns\HandlesCashTransactions;
@ -19,6 +16,7 @@
class PayrollPeriodService class PayrollPeriodService
{ {
use HandlesCashTransactions; use HandlesCashTransactions;
public function getAll(array $filters = []): Collection public function getAll(array $filters = []): Collection
{ {
return PayrollPeriod::select('id', 'year', 'month', 'status', 'closed_at', 'created_at') return PayrollPeriod::select('id', 'year', 'month', 'status', 'closed_at', 'created_at')

1
app/Services/Admin/Manage/RestockService.php
View File

@ -241,5 +241,4 @@ private function buildItemRows(array $items, string $stockType, $now, int &$subt
]; ];
})->toArray(); })->toArray();
} }
} }

1
app/Services/Concerns/HandlesCashTransactions.php
View File

@ -5,7 +5,6 @@
use App\Enums\CashTransactionType; use App\Enums\CashTransactionType;
use App\Models\CashAccount; use App\Models\CashAccount;
use App\Models\CashTransaction; use App\Models\CashTransaction;
use Illuminate\Support\Facades\DB;
use Illuminate\Validation\ValidationException; use Illuminate\Validation\ValidationException;
trait HandlesCashTransactions trait HandlesCashTransactions

3
app/Services/Concerns/HasStockAdjustment.php
View File

@ -3,6 +3,7 @@
namespace App\Services\Concerns; namespace App\Services\Concerns;
use App\Enums\ProductStockQuality; use App\Enums\ProductStockQuality;
use App\Models\ProductVariant;
use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Model;
trait HasStockAdjustment trait HasStockAdjustment
@ -26,7 +27,7 @@ private function adjustVariantStock(int $variantId, int $quantity, int $sign, st
$field = self::QUALITY_STOCK_MAP[$stockType] ?? 'stock'; $field = self::QUALITY_STOCK_MAP[$stockType] ?? 'stock';
$this->adjustStock( $this->adjustStock(
model: app(\App\Models\ProductVariant::class)->newQuery()->findOrFail($variantId), model: app(ProductVariant::class)->newQuery()->findOrFail($variantId),
field: $field, field: $field,
quantity: $quantity, quantity: $quantity,
sign: $sign, sign: $sign,