dst/dstpabuaran.com
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: optimize product name retrieval and enhance category selection in ProductIndex component

Browse Source
This commit is contained in:
Yoga Pangestu 2026-08-12 20:38:11 +07:00
parent ff8dc64a27
commit 278493b4c6
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/Services/Admin/Master/Product/ProductService.php
View File

@ -27,8 +27,9 @@ public function __construct(
public function getNames(): Collection public function getNames(): Collection
{ {
return Product::select(['id', 'name']) return Product::select('name')
->get(); ->distinct()
->pluck('name');
} }
public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc', array $filters = []): LengthAwarePaginator public function paginated(int $perPage = 25, string $search = '', string $sort = 'created_at', string $direction = 'desc', array $filters = []): LengthAwarePaginator

5
resources/js/pages/admin/master/product/index.tsx
View File

@ -168,7 +168,7 @@ export default function ProductIndex({ products, categories, productNames, filte
</ComboboxEmpty> </ComboboxEmpty>
<ComboboxList> <ComboboxList>
{(name) => ( {(name) => (
<ComboboxItem value={name}>{name}</ComboboxItem> <ComboboxItem key={name} value={name}>{name}</ComboboxItem>
)} )}
</ComboboxList> </ComboboxList>
</ComboboxContent> </ComboboxContent>
@ -224,6 +224,7 @@ export default function ProductIndex({ products, categories, productNames, filte
<Combobox <Combobox
items={categories} items={categories}
itemToStringLabel={(cat) => cat.name} itemToStringLabel={(cat) => cat.name}
getOptionAsValue={(cat) => String(cat.id)}
value={selectedCategory} value={selectedCategory}
onValueChange={(value) => onValueChange={(value) =>
applyFilter('category', value ? String(value.id) : '') applyFilter('category', value ? String(value.id) : '')
@ -239,7 +240,7 @@ export default function ProductIndex({ products, categories, productNames, filte
</ComboboxEmpty> </ComboboxEmpty>
<ComboboxList> <ComboboxList>
{(cat) => ( {(cat) => (
<ComboboxItem value={cat}> <ComboboxItem key={cat.id} value={cat}>
{cat.name} {cat.name}
</ComboboxItem> </ComboboxItem>
)} )}